Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.1] Add RewriteBase directive template in .htaccess file into pub/static folder #13812

Merged

Conversation

ccasciotti
Copy link
Contributor

Backport of pull request #13678

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
MAGETWO-88277 has been created to process this Pull Request

@TomashKhamlai
Copy link
Contributor

@ccasciotti, please provide manual test scenario.
As far as I could understand, I have to uncomment the expression added to {web_root}/{doc_root}/pub/static/.htaccess file and replace 'magento' to the real {doc_root} where Magento was installed.

Could you please describe next steps that will demonstrate the advantages of these changes?

@ccasciotti
Copy link
Contributor Author

@TomashKhamlai as I described in original pull request, this PR adds RewriteBase directive into .htaccess file into pub/static folder, in case the need is to install Magento code under a directory inside the web root. Setting this directive into .htaccess file in Magento root and without setting it into .htaccess under pub/static folder cause a file missing (js and css) by Apache Web Server

@okorshenko okorshenko modified the milestones: February 2018, March 2018 Mar 1, 2018
@magento-engcom-team magento-engcom-team merged commit 3b20c8e into magento:2.1-develop Mar 6, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants